Lang tid om at loade siden

[Mathias]

Hej, min side http://dragonegcraft.dk/ er lang tid om at loade kan ikke se hvorfor, ved heller ikke om den gør med andres. Men her er koderene vis nu noget skulle gøre den langsom.

users.php

Kode: Vælg alt

<?php
function update_user($update_data) {
        global $session_user_id;
    
        $update = array();
	array_walk($update_data, 'array_sanitize');
	
        foreach ($update_data as $field=>$data) {
            $update[] = '`' . $field . '` = \'' . $data . '\'';
        }
        
	mysql_query("UPDATE `users` SET " . implode(', ', $update ) . " WHERE `user_id` = $session_user_id");
}

function change_password($user_id, $password) {
	$user_id = (int)$user_id;
	$password = md5($password);
	
	mysql_query("UPDATE `users` SET `password` = '$password' WHERE `user_id` = '$user_id'");
}

function register_user($register_data) {
	array_walk($register_data, 'array_sanitize');
	$register_data['password'] = md5($register_data['password']);
	
	$fields = '`' . implode('`, `', array_keys($register_data)) . '`';
	$data = '\'' . implode('\', \'', $register_data) . '\'';
	
	mysql_query("INSERT INTO `users` ($fields) VALUES ($data)");
}

function user_count() {
	return mysql_result(mysql_query("SELECT COUNT(`user_id`) FROM `users` WHERE `active` = 1"), 0);	
}

function user_data($user_id) {
	$data = array();
	$user_id = (int)$user_id;
	
	$func_num_args = func_num_args();
	$func_get_args = func_get_args();
	
	if ($func_num_args > 1) {
		unset($func_get_args[0]);
		$fields = '`' . implode('`, `', $func_get_args) . '`';
		$data = mysql_fetch_assoc(mysql_query("SELECT $fields FROM `users` WHERE `user_id` = $user_id"));
		return $data;
	}
}

function logged_in($login) {
	return (isset($_SESSION['user_id'])) ? true : false;	
}

function user_exists($username) {
	$username = sanitize($username);
	return (mysql_result(mysql_query("SELECT COUNT(`user_id`) FROM `users` WHERE `username` = '$username'"), 0) == 1) ? true : false;	
}

function email_exists($email) {
	$email = sanitize($email);
	return (mysql_result(mysql_query("SELECT COUNT(`user_id`) FROM `users` WHERE `email` = '$email'"), 0) == 1) ? true : false;	
}

function user_active($username) {
   $username = sanitize($username);
   return (mysql_result(mysql_query("SELECT COUNT(`user_id`) FROM `users` WHERE `username` = '$username' AND `active` = 1"), 0) == 1) ? true : false;   
}

function user_id_from_username($username) {
    $username  = sanitize($username);
    return mysql_result(mysql_query("SELECT `user_id` FROM `users` WHERE `username` = '$username'"), 0, 'user_id');
}

function login($username, $password) {
	$user_id = user_id_from_username($username);
	
	$username = sanitize($username);
	$password = md5($password);
	
	return (mysql_result(mysql_query("SELECT COUNT(`user_id`) FROM `users` WHERE `username` = '$username' AND `password` = '$password'"), 0) == 1) ? $user_id : false;
}
?>

general.php

Kode: Vælg alt

<?php
function logged_in_redirect() {
	if (logged_in() === true) {
		header("Location: index.php");
		exit();
	}
}

function protect_page() {
	if (logged_in() === false) {
		header("Location: kun_bruger_ingen_adgang.php");
		exit();
	}
}

function array_sanitize(&$item) {
	$item = mysql_real_escape_string($item);
}

function sanitize($data) {
	return mysql_real_escape_string($data);	
}

function output_errors($errors) {
	$output = array();
	foreach($errors as $error) {
		$output[] = '<li>' . $error . '</li>';
	}
	return '<ul>' . implode('', $output) . '</ul>';
}
?>

int.php

Kode: Vælg alt

<?php
session_start();
error_reporting(0);
require 'script_database/connect.php';
require 'script_database/general.php';
require 'script_database/users.php';

if (logged_in() === true) {
	$session_user_id = $_SESSION['user_id'];
	$user_data = user_data($_SESSION['user_id'], 'user_id', 'username', 'password', 'first_name', 'last_name', 'email');
	
	if (user_active($user_data['username']) === false) {
		session_destroy();
		header("Location: index.php");
		exit();
	}
}

$errors = array();
?>

.htaccess

Kode: Vælg alt

RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)$ /profil.php?username=$1

Det er alle include filerne, så det må være en af dem, vis den er langsom for jer.

[scootergrisen]

Det er http://dragonegcraft.dk/script_database ... adgang.php som viderestiller til sig selv.

[Mathias]

Undskyld men kan ikke se det fulde link, kan du eventuelt, skrive det uden http?

[scootergrisen]

Du skal bare trykke på linket.

[Mathias]

Det kan jeg bare ikke se den gør

Kode: Vælg alt

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> 
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> 
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> 
<title>ISDK</title>
<link href="css/main.css" rel="stylesheet" />
<script src="script_database/jquery-1.8.3.js" type="text/javascript"></script>
<script src="script_database/selector.js" type="text/javascript"></script>
</head>
<body>
	<div id="wrapper">
	<header id="top_header">
    	<h1>ISDK</h1>
        <?php
include 'menu.php';
?>
    </header>
    
    <section id="main_section">
    	<article>
        </article>
    </section>
    
    <aside id="side_news">
                    <?php
	include 'int.php';
	?>
			<?php
			if(isset($_SESSION['user_id'])) {
				include 'brugerdata.php';	
			} else {
			include 'login_form.php';
			}
			?>
    </aside>
    <footer id="the_footer">
    	<h3>Vi har så mange bruger registret <?php echo user_count(); ?></h3>
    </footer>
	</div>
</body>
</html>

Altså hvor skulle den der. Vis du kan skrive koden ville det være rart. Har set den viderstiller sig selv, men hvordan er spørgsmålet?.

[scootergrisen]

Nu ser det ud til at virke.
Så mangler du bare at rette din HTML kode : http://validator.w3.org/check?uri=http% ... ne&group=0

[Mathias]

Det virker ikke kan ikke se hvor den header er eller hvad den hedder den gør det stadig.

[scootergrisen]

Kode: Vælg alt

function logged_in_redirect() {
   if (logged_in() === true) {
      header("Location: index.php");
      exit();
   }
}

function protect_page() {
   if (logged_in() === false) {
      header("Location: kun_bruger_ingen_adgang.php");
      exit();
   }
}